This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Fix deprecation notice with zend-expressive-router 2.4 for config driven apps #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates the ApplicationConfigInjectionTrait to use `prepareMiddleware()` before calling `route()`; this ensures that `Route` instances only ever receive middleware instances. - Provides changes to tests to ensure they work with the 2.4 version of the router. Primarily this means mocking the `MiddlewareInterface` when providing middleware to pipe or route against when we are not testing for that particular middleware. Additionally, it modifies the "assertRoute" expectations to simply ensure we _have_ middleware, but not the type; decorators are often in play, even in the existing 2.X series.
weierophinney
added a commit
that referenced
this pull request
Mar 9, 2018
weierophinney
added a commit
that referenced
this pull request
Mar 9, 2018
weierophinney
added a commit
that referenced
this pull request
Mar 9, 2018
weierophinney
added a commit
that referenced
this pull request
Mar 9, 2018
Forward port #583 Conflicts: CHANGELOG.md src/Container/ApplicationConfigInjectionDelegator.php test/Container/ApplicationConfigInjectionDelegatorTest.php test/Container/ApplicationFactoryTest.php test/Middleware/DispatchMiddlewareTest.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://discourse.zendframework.com/t/strange-behaviour-of-implicitoptionsmiddleware-with-multiple-route-on-same-path/496
There is more tests failing now, so it needs some improvements...