This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Add Pimple 3 support #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essive-composer-installer into feature/pimple-3-support
weierophinney
added a commit
that referenced
this pull request
Dec 21, 2015
weierophinney
added a commit
to weierophinney/zend-expressive
that referenced
this pull request
Dec 21, 2015
Following on zendframework/zend-expressive-skeleton#49, this patch updates the codebase to recommend xtreamwayz/pimple-container-interop for Pimple users. This is to ensure developers are using the latest stable release of Pimple (currently v3), and using a container with the same public API as Pimple itself.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on IRC last night.
@weierophinney NOTE: Because of the new tests you have to make a choice if you want pimple 1 or 3 support. You can't have both since all dependencies are loaded once. This pull request has to be rebased and updated once the new tests are merged from #48.