Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Changing Pimple DI container #47

Closed
wants to merge 2 commits into from
Closed

Changing Pimple DI container #47

wants to merge 2 commits into from

Conversation

Sam-Burns
Copy link

No description provided.

@Sam-Burns
Copy link
Author

@geerteltink
Copy link
Member

I didn't test this code but I'm pretty sure it doesn't work. You can't just change the namespace and expect it to work. You need to figure out how to inject the configuration into your class. It would be a lot easier if you just extend the Pimple class instead of building a wrapper around it.

Besides that, the config.php file was build for pimple 1. There have been some changes in pimple 3.

@Sam-Burns
Copy link
Author

@xtreamwayz The config gets injected here, doesn't it? My container wrapper should be a drop-in replacement for the one you were using before, so I'm sure that injection will work ok.

weierophinney added a commit that referenced this pull request Dec 21, 2015
@weierophinney
Copy link
Member

Superceded by #49

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants