Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Court into the Runtime #276

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Integrate Court into the Runtime #276

merged 1 commit into from
Sep 7, 2021

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Aug 25, 2021

Depends on #248
Fixes #200 #281

@c410-f3r
Copy link
Contributor Author

c410-f3r commented Sep 7, 2021

Should be good now

Copy link
Member

@lsaether lsaether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we may want to make some future enhancements to how Binary markets (2 outcome Categorical) handles slashing the losing side, and reducing slashing to 1/2 or some fixed percentage of staked, but I think for now this is good.

Also, slashed jurors should be removed from the Juror pool, requiring them to re-stake if they want to be a juror again. I didn't see this logic in on_resolution, can you point it out to me if it exists? Otherwise, let's create an issue for that and go ahead merge this in.

@c410-f3r
Copy link
Contributor Author

c410-f3r commented Sep 7, 2021

Looks good. I think we may want to make some future enhancements to how Binary markets (2 outcome Categorical) handles slashing the losing side, and reducing slashing to 1/2 or some fixed percentage of staked, but I think for now this is good.

Also, slashed jurors should be removed from the Juror pool, requiring them to re-stake if they want to be a juror again. I didn't see this logic in on_resolution, can you point it out to me if it exists? Otherwise, let's create an issue for that and go ahead merge this in.

https://github.com/zeitgeistpm/zeitgeist/pull/276/files#diff-98309a49dd69a9828c5d52abdaceaa49ea571cfd6e3c98f340484172605d9943R252-R267

This closure is called everytime an already tardy juror does not vote or votes after the maximum allowed block number

@c410-f3r
Copy link
Contributor Author

c410-f3r commented Sep 7, 2021

I will then merge it now, thanks

@c410-f3r c410-f3r merged commit 270d24f into main Sep 7, 2021
@c410-f3r c410-f3r deleted the caio-c8 branch September 9, 2021 12:42
@sea212 sea212 added the s:accepted This pull request is ready for merge label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Court Pallet
3 participants