Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Court] JurorsStatus::Tardy juror will never be changed back to JurorStatus::Ok #291

Closed
c410-f3r opened this issue Sep 7, 2021 · 2 comments · Fixed by #305
Closed

[Court] JurorsStatus::Tardy juror will never be changed back to JurorStatus::Ok #291

c410-f3r opened this issue Sep 7, 2021 · 2 comments · Fixed by #305
Labels
p:low Low priority, resolution of this issue can wait t:maintenance The issue describes necessary maintenance

Comments

@c410-f3r
Copy link
Contributor

c410-f3r commented Sep 7, 2021

Once a juror is marked as JurorStatus::Tardy, he will always be tardy and I am not sure if this behaviour is desired.

@c410-f3r c410-f3r added p:low Low priority, resolution of this issue can wait t:maintenance The issue describes necessary maintenance labels Sep 7, 2021
@ckamm
Copy link

ckamm commented Sep 8, 2021

It looks to me like this causes issues. In a subsequent dispute a tardy juror will neither receive an incentive when voting for the best option, nor will their stake be slashed when voting for something other than the best two options. See slash_losers_to_award_winners use of non_tardy_jurors_with_votes.

@c410-f3r
Copy link
Contributor Author

c410-f3r commented Sep 8, 2021

Yes, already tardy jurors that voted within the CourtCaseDuration duration are valid and should be eligible to receive rewards or be slashed, therefore, non_tardy_jurors_with_votes could be renamed to something like valid_jurors_with_votes and also yield valid tardy jurors.

Thanks again for spotting another problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p:low Low priority, resolution of this issue can wait t:maintenance The issue describes necessary maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants