Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support automatic removal of needs release notes #2781

Merged

Conversation

moradology
Copy link
Contributor

@moradology moradology commented Jan 30, 2025

This PR updates the Pull Request Labeler configuration to use all/all matching criteria instead of the previous any/any setup for the needs release notes label. This change makes it so that the label is automatically removed when a changes/*.rst file is added/modified in the PR.

Fixes: #2779

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jan 30, 2025
@moradology
Copy link
Contributor Author

This is purely CI so I'm not sure it warrants further attention but I'll add to changes/ if that's desirable

@joshmoore
Copy link
Member

From my side, not a must but it would test the change 😉

@moradology
Copy link
Contributor Author

I'm not sure it would. If I'm not mistaken, because labeler uses pull_request_target for permissions reasons, these changes won't be effective on PRs until it's already in the base/target branch

@moradology moradology force-pushed the fix/remove-labels-automatically branch from 8b374bf to b28ed9d Compare January 30, 2025 19:05
@moradology
Copy link
Contributor Author

moradology commented Jan 31, 2025

After this is in, maybe someone with perms would be kind of enough to fire off CI for a PR we know should already have its changes/*.rst added

@jhamman jhamman merged commit 3c4ac0f into zarr-developers:main Jan 31, 2025
30 checks passed
@jhamman
Copy link
Member

jhamman commented Jan 31, 2025

Looks like this did not work. I'll reopen the issue.

@moradology
Copy link
Contributor Author

Oh man, there's nothing quite like the developer experience of working on CI and airing all the dirty laundry of a local dev experience in a chain of emails that go out to all maintainers of a project 😭

@d-v-b
Copy link
Contributor

d-v-b commented Jan 31, 2025

i think without a reliable way to run github actions locally, this iteration has to happen in the open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labeler action doesn't remove "needs release notes" labels
4 participants