-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support automatic removal of needs release notes
#2781
Support automatic removal of needs release notes
#2781
Conversation
This is purely CI so I'm not sure it warrants further attention but I'll add to |
From my side, not a must but it would test the change 😉 |
I'm not sure it would. If I'm not mistaken, because labeler uses |
8b374bf
to
b28ed9d
Compare
After this is in, maybe someone with perms would be kind of enough to fire off CI for a PR we know should already have its |
Looks like this did not work. I'll reopen the issue. |
Oh man, there's nothing quite like the developer experience of working on CI and airing all the dirty laundry of a local dev experience in a chain of emails that go out to all maintainers of a project 😭 |
i think without a reliable way to run github actions locally, this iteration has to happen in the open |
This PR updates the Pull Request Labeler configuration to use all/all matching criteria instead of the previous any/any setup for the
needs release notes
label. This change makes it so that the label is automatically removed when achanges/*.rst
file is added/modified in the PR.Fixes: #2779
TODO:
docs/user-guide/*.rst
changes/