Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labeler action doesn't remove "needs release notes" labels #2779

Closed
dstansby opened this issue Jan 30, 2025 · 3 comments · Fixed by #2781
Closed

Labeler action doesn't remove "needs release notes" labels #2779

dstansby opened this issue Jan 30, 2025 · 3 comments · Fixed by #2781

Comments

@dstansby
Copy link
Contributor

The labeler action doesn't seem to be removing "needs release notes" labels when release notes are correclty added to PRs. This should be fixed so when a release note is added, the label is automatically removed.

Not sure if this is an issue with our config, or a bug with the labeler action.

@moradology
Copy link
Contributor

Looks to me like bad configuration. sync-labels is set up appropriately, but the rule currently is to add the label if ANY change is made to a file not in changes/*.rst. Sync can only change things if that condition is voided later, which seems unlikely. We probably want all/all, based on https://github.com/actions/labeler and my now-quite-rusty mastery of syllogistic logic

@jhamman
Copy link
Member

jhamman commented Jan 31, 2025

@jhamman
Copy link
Member

jhamman commented Jan 31, 2025

Okay, all good now. Thanks @moradology.

Ref showing that this is working on active PRs -> #2778 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants