Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on numpy 1.23 #2124

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Run tests on numpy 1.23 #2124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ jobs:
python-version: ['3.10', '3.11', '3.12']
numpy_version: ['>=1.24.0', '==1.23.*']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should do this now:

Suggested change
numpy_version: ['>=1.24.0', '==1.23.*']
numpy_version: ['==1.24*', '==1.26*', '>=2.1]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there big differences between 1.24 and 1.26 that make it worth testing on both of them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm betting that there are a number of projects that are stuck on 1.26 while they sort out numpy 2 compatibility. The main thrust of my comment is that 1.24 is our current support minimum (https://scientific-python.org/specs/spec-0000/).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still 1.23 on main:

zarr-python/pyproject.toml

Line 16 in 2e928b1

'numpy>=1.23',
. Maybe we could merge this PR, and then bump to 1.24 in another PR (that should have an entry in the release notes)?

exclude:
- python-version: '3.10'
numpy_version: '==1.23.*'
- python-version: '3.11'
numpy_version: '==1.23.*'
- python-version: '3.12'
Expand Down
Loading