-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test matrix for V3 #1656
Add test matrix for V3 #1656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @maxrjones. A few suggestions but this is close to going in.
hatch run test:run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if we could use github action's matrix feature here as well. Obviously, we're skipping lots of tests at the moment so running the whole matrix in one action is fine. But as the test suite comes back to life, I think we'll spread out. It seems like Hatch can support this with something like:
hatch run +py=${{ matrix.python-version }} test:run
Note: I wasn't able to figure out how to run individual matrix members with hatch variable selection but it seems like it should be possible: https://hatch.pypa.io/1.9/cli/reference/#hatch-env-run
Co-authored-by: Joe Hamman <[email protected]>
I'm going to merge this now since I think its a solid improvement. @maxrjones - if you come back to #1648, we can look into splitting the matrix runs out into a GHA matrix. |
Thanks @jhamman! I'll be offline Feb 14 - March 5 and doubt that I will have time to work on this more before then. But, I'll be glad to contribute more after returning if there are still open V3 refactor issues. |
Part of #1648
The
extras
are packages that should be optional (with import skipping), which could be addressed separately.The current setup includes 8 combinations (below), would appreciate feedback on this.