Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Test environments and CI #1648

Closed
5 of 6 tasks
Tracked by #2412
jhamman opened this issue Feb 6, 2024 · 7 comments · Fixed by #2431
Closed
5 of 6 tasks
Tracked by #2412

[v3] Test environments and CI #1648

jhamman opened this issue Feb 6, 2024 · 7 comments · Fixed by #2431
Labels
help wanted Issue could use help from someone with familiarity on the topic tests
Milestone

Comments

@jhamman
Copy link
Member

jhamman commented Feb 6, 2024

We just merged #1592 which should make managing our various test environments much easier going forward. This ticket lays out a number of small tasks that can be taken to modernize our test environments and GitHub Actions Workflows. I'm sure I'm missing a few things here so feel free to comment / suggest alternatives.

Hatch related improvements

  • Define dev environments in pyproject.toml using Hatch environments
    • Move requirements_dev_*.txt defining separate environments for "minimal", "dev". These should include parameterizations over python versions (3.10 and 3.11).
    • Use these environments in our GitHub actions
  • Split out "minimal" environment into two separate environments
  • Create "docs" environment so developers can simply run: hatch run docs:serve

GitHub Actions related improvements

  • Explore removing the need to install a conda environment, instead relying on pure hatch environments
  • Explore combining the "windows", "minimal", and "python-package" workflows into a single workflow
  • Run Mypy checks in each matrix run in addition to our pre-commit script
@jhamman jhamman added help wanted Issue could use help from someone with familiarity on the topic V3 labels Feb 6, 2024
@rabernat
Copy link
Contributor

rabernat commented Feb 6, 2024

I want to help with this and am motivated to get it done by tomorrow in time for the Zarr sprint.

@jhamman
Copy link
Member Author

jhamman commented Feb 6, 2024

Quick update here. @rabernat got a good start on an initial Hatch env / CI setup in #1650. Still more to do here thought so leaving this open with the flag: help wanted.

@maxrjones
Copy link
Member

I'm planning to work on this at the Zarr sprint today, unless Ryan or others already plan to

@jhamman jhamman moved this to Todo in Zarr-Python - 3.0 Apr 5, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone Apr 5, 2024
@jhamman jhamman changed the title Test environments and CI in v3 [v3] Test environments and CI Apr 5, 2024
@jhamman jhamman added the tests label Apr 5, 2024
@maxrjones
Copy link
Member

FYI I think the initial task list in this issue is complete now that #1728 is merged

@jhamman jhamman moved this from Todo to In Progress in Zarr-Python - 3.0 May 11, 2024
@jhamman jhamman modified the milestones: 3.0.0.alpha, 3.0.0 May 24, 2024
@dstansby
Copy link
Contributor

Yep, I think this can be closed

@jhamman
Copy link
Member Author

jhamman commented Jul 2, 2024

Before we do, it would be nice to get a windows test environment up and running.

@jhamman
Copy link
Member Author

jhamman commented Oct 21, 2024

After #2423 and #2418 go in, the last thing here is to get some diversity in platform into the test suite. Would be good to get at least 1 windows and MacOS entry in the main test matrix.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Zarr-Python - 3.0 Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issue could use help from someone with familiarity on the topic tests
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants