Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace assert with require in critical parts #409

Merged
merged 1 commit into from
Mar 19, 2022
Merged

Replace assert with require in critical parts #409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/e2e/e2e_composability_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ func TestE2eExampleComposability(t *testing.T) {

// Right now we're just checking that `curl` returns 0. It can be enhanced by scraping the HTML that gets returned or something.
resp, err := http.Get("http://127.0.0.1:22333?doom")
assert.NoError(t, err, resp)
require.NoError(t, err, resp)

// Read the body into string
body, err := io.ReadAll(resp.Body)
assert.NoError(t, err, body)
require.NoError(t, err, body)

// Validate the doom title in body.
assert.Contains(t, string(body), "Zarf needs games too")
Expand Down