Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace assert with require in critical parts #409

Merged
merged 1 commit into from
Mar 19, 2022

Conversation

RobertKwiatkowski
Copy link
Contributor

@RobertKwiatkowski RobertKwiatkowski commented Mar 18, 2022

Description

Now using require.NoError in test parts which are critical

Related Issue

Fixes #405

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist before merging

Now using require.NoError in test parts which are critical
Copy link
Contributor

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@RothAndrew RothAndrew merged commit 4c0d1a2 into zarf-dev:master Mar 19, 2022
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Now using require.NoError in test parts which are critical
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Testify's require.NoError instead of assert.NoError in tests
3 participants