Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export setupMessage function #3221

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Nov 8, 2024

Description

Export Zarf's root command message setup function:

zarf/src/cmd/root.go

Lines 211 to 220 in 36b779f

type messageCfg struct {
level string
skipLogFile bool
noColor bool
// featureDisabled is a feature flag that disables it
featureDisabled bool
}
// setupMessage configures message while we migrate over to logger.
func setupMessage(cfg messageCfg) error {

UDS CLI uses Zarf as a library in parts and we'd like to be able to configure how Zarf does some outputting. In Zarf versions before v0.42.1, there was a common function to do so, but it's since been refactored and now unavailable to us.

Checklist before merging

@catsby catsby requested review from a team as code owners November 8, 2024 16:55
Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 05bbb4b
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/672e5349bacbcf0008a0a181

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cmd/root.go 0.00% 11 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/root.go 0.00% <0.00%> (ø)

* main:
  chore(deps): bump golang.org/x/term from 0.25.0 to 0.26.0 (zarf-dev#3220)
  chore(deps): bump goreleaser/goreleaser-action from 6.0.0 to 6.1.0 (zarf-dev#3216)
  chore: true up logger comments and minor refactors (zarf-dev#3215)
  chore(deps): bump golang.org/x/sync from 0.8.0 to 0.9.0 (zarf-dev#3218)

Signed-off-by: catsby <[email protected]>
@catsby catsby force-pushed the export-setup-message branch from b27a093 to 05bbb4b Compare November 8, 2024 18:07
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Nov 8, 2024
Merged via the queue into zarf-dev:main with commit f4c80cb Nov 8, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants