chore: true up logger comments and minor refactors #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kit Patella <[email protected]>
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
|
|
Cleanup related to #3210 |
AustinAbro321
approved these changes
Nov 8, 2024
catsby
added a commit
to catsby/zarf
that referenced
this pull request
Nov 8, 2024
* main: chore(deps): bump golang.org/x/term from 0.25.0 to 0.26.0 (zarf-dev#3220) chore(deps): bump goreleaser/goreleaser-action from 6.0.0 to 6.1.0 (zarf-dev#3216) chore: true up logger comments and minor refactors (zarf-dev#3215) chore(deps): bump golang.org/x/sync from 0.8.0 to 0.9.0 (zarf-dev#3218)
catsby
added a commit
to catsby/zarf
that referenced
this pull request
Nov 8, 2024
* main: chore(deps): bump golang.org/x/term from 0.25.0 to 0.26.0 (zarf-dev#3220) chore(deps): bump goreleaser/goreleaser-action from 6.0.0 to 6.1.0 (zarf-dev#3216) chore: true up logger comments and minor refactors (zarf-dev#3215) chore(deps): bump golang.org/x/sync from 0.8.0 to 0.9.0 (zarf-dev#3218) Signed-off-by: catsby <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix some comments that weren't updated when logger From was simplified and shuffle some impl. details around for readability, flow, vibes etc.
Checklist before merging