chore: update flux example, tests, and docs to address upstream fix

examples/podinfo-flux/zarf.yaml

@@ -11,14 +11,14 @@ components:
       - name: flux-install
         namespace: flux
         files:
-          - https://github.com/fluxcd/flux2/releases/download/v2.3.0/install.yaml
+          - https://github.com/fluxcd/flux2/releases/download/v2.4.0/install.yaml
     images:
-      - ghcr.io/fluxcd/helm-controller:v1.0.1
-      - ghcr.io/fluxcd/image-automation-controller:v0.38.0
-      - ghcr.io/fluxcd/image-reflector-controller:v0.32.0
-      - ghcr.io/fluxcd/kustomize-controller:v1.3.0
-      - ghcr.io/fluxcd/notification-controller:v1.3.0
-      - ghcr.io/fluxcd/source-controller:v1.3.0
+      - ghcr.io/fluxcd/helm-controller:v1.1.0
+      - ghcr.io/fluxcd/image-automation-controller:v0.39.0
+      - ghcr.io/fluxcd/image-reflector-controller:v0.33.0
+      - ghcr.io/fluxcd/kustomize-controller:v1.4.0
+      - ghcr.io/fluxcd/notification-controller:v1.4.0
+      - ghcr.io/fluxcd/source-controller:v1.4.1
 
   - name: podinfo-via-flux-git
     description: Example deployment via flux (git) using the famous podinfo example
@@ -108,6 +108,4 @@ x-mdx: |
 
   The Zarf agent will only automatically add the `insecure` key if the internal registry is used. If you are using a http registry outside of the cluster you will need to manually add this key.
 
-  Due to an upstream bug, HelmRepositories with an insecure registry must use IP address instead of a hostname. This is not an issue with the internal Zarf registry, which is always an IP address, but will cause Flux HelmRepositories to break if Zarf is using an external http registry with a hostname.
-
   :::

site/src/content/docs/ref/init-package.mdx

@@ -157,12 +157,6 @@ The `zarf-agent` modifies the following [flux](https://fluxcd.io/flux/) resource
 
 > Support for mutating OCIRepository and HelmRepository objects is in [`alpha`](/roadmap#alpha) and should be tested on non-production clusters before being deployed to production clusters.
 
-:::caution
-
-Due to a bug in helm, HelmRepositories with an insecure registry must use IP address instead of a hostname. This is not an issue with the internal Zarf registry, which is always an IP address, but will cause Flux HelmRepositories to break if Zarf is using an external http registry with a hostname.
-
-:::
-
 The `zarf-agent` modifies [ArgoCD applications](https://argo-cd.readthedocs.io/en/stable/user-guide/application-specification/) & [ArgoCD Repositories](https://argo-cd.readthedocs.io/en/stable/user-guide/private-repositories/)  objects to point to the local Git Server.
 
 > Support for mutating `Application` and `Repository` objects in ArgoCD is in [`beta`](/roadmap#beta) and should be tested on non-production clusters before being deployed to production clusters.

src/test/external/ext_out_cluster_test.go

@@ -30,7 +30,6 @@ const (
 	subnet         = "172.31.0.0/16"
 	gateway        = "172.31.0.1"
 	giteaIP        = "172.31.0.99"
-	registryIP     = "172.31.0.10"
 	giteaHost      = "gitea.localhost"
 	registryHost   = "registry.localhost"
 	clusterName    = "zarf-external-test"
@@ -45,9 +44,7 @@ var outClusterCredentialArgs = []string{
 	"--git-url=http://" + giteaHost + ":3000",
 	"--registry-push-username=" + registryUser,
 	"--registry-push-password=" + commonPassword,
-	// TODO @AustinAbro321 once flux updates to a version of helm using ORAS v1.2.5 or greater we can switch back
-	// to using the registry host rather than creating an IP https://github.com/helm/helm/pull/12998
-	"--registry-url=" + registryIP + ":5000"}
+	"--registry-url=k3d-" + registryHost + ":5000"}
 
 type ExtOutClusterTestSuite struct {
 	suite.Suite
@@ -61,7 +58,7 @@ func (suite *ExtOutClusterTestSuite) SetupSuite() {
 	// NOTE(mkcp): We dogsled these errors because some of these commands will error if they don't cleanup a resource,
 	//   which is ok. A better solution would be checking for none or unexpected kinds of errors.
 	_ = exec.CmdWithPrint("k3d", "cluster", "delete", clusterName)   // TODO(mkcp): intentionally ignored, mark nolint
-	_ = exec.CmdWithPrint("docker", "rm", "-f", "k3d-"+registryHost) // TODO(mkcp): intentionally ignored, mark nolint
+	_ = exec.CmdWithPrint("k3d", "registry", "delete", registryHost) // TODO(mkcp): intentionally ignored, mark nolint
 	_ = exec.CmdWithPrint("docker", "compose", "down")               // TODO(mkcp): intentionally ignored, mark nolint
 	_ = exec.CmdWithPrint("docker", "network", "remove", network)    // TODO(mkcp): intentionally ignored, mark nolint
 
@@ -70,12 +67,12 @@ func (suite *ExtOutClusterTestSuite) SetupSuite() {
 	suite.NoError(err, "unable to create the k3d registry")
 
 	// Install a k3d-managed registry server to act as the 'remote' container registry
-	err = exec.CmdWithPrint("docker", "run", "-d", "--restart=always", "-p", "5000:5000", "--name", "k3d-"+registryHost, "registry:2.8.3")
+	err = exec.CmdWithPrint("k3d", "registry", "create", registryHost, "--port", "5000")
 	suite.NoError(err, "unable to create the k3d registry")
 
 	// Create a k3d cluster with the proper networking and aliases
-	err = exec.CmdWithPrint("k3d", "cluster", "create", clusterName, "--registry-config", "registries.yaml",
-		"--host-alias", registryIP+":"+registryHost, "--host-alias", giteaIP+":"+giteaHost, "--network", network)
+	err = exec.CmdWithPrint("k3d", "cluster", "create", clusterName, "--registry-use",
+		"k3d-"+registryHost+":5000", "--host-alias", giteaIP+":"+giteaHost, "--network", network)
 	suite.NoError(err, "unable to create the k3d cluster")
 
 	// Install a gitea server via docker compose to act as the 'remote' git server
@@ -90,8 +87,6 @@ func (suite *ExtOutClusterTestSuite) SetupSuite() {
 	// Connect gitea to the k3d network
 	err = exec.CmdWithPrint("docker", "network", "connect", "--ip", giteaIP, network, giteaHost)
 	suite.NoError(err, "unable to connect the gitea-server to k3d")
-	err = exec.CmdWithPrint("docker", "network", "connect", "--ip", registryIP, network, "k3d-"+registryHost)
-	suite.NoError(err, "unable to connect the registry-server to k3d")
 }
 
 func (suite *ExtOutClusterTestSuite) TearDownSuite() {
@@ -102,7 +97,7 @@ func (suite *ExtOutClusterTestSuite) TearDownSuite() {
 	err = exec.CmdWithPrint("docker", "compose", "down")
 	suite.NoError(err, "unable to teardown the gitea-server")
 
-	err = exec.CmdWithPrint("docker", "rm", "-f", "k3d-"+registryHost)
+	err = exec.CmdWithPrint("k3d", "registry", "delete", registryHost)
 	suite.NoError(err, "unable to teardown the k3d registry")
 
 	err = exec.CmdWithPrint("docker", "network", "remove", network)