chore: update flux example, tests, and docs to address upstream fix #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Austin Abro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
AustinAbro321
changed the title
AustinAbro321
changed the title
phillebaba
approved these changes
Oct 3, 2024
ittacco
pushed a commit
to ittacco/zarf
that referenced
this pull request
Nov 9, 2024
…arf-dev#3052) Signed-off-by: Austin Abro <[email protected]> Signed-off-by: ittacco <[email protected]>
Jneville0815
pushed a commit
to radiusmethod/zarf
that referenced
this pull request
Dec 12, 2024
…arf-dev#3052) Signed-off-by: Austin Abro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an issue with past version of flux that stemmed from a bad regex in docker, that caused ocirepos to fail when using a hostname (as opposed to an ip address) over insecure http connections. We made some changes in the test to account for that. Now that it's fixed in the upstream(s), we can change the test back and delete our caution notes.
Checklist before merging