fix: health checks issue when crds don't exist prior to package deploys #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Signed-off-by: Austin Abro <[email protected]>
AustinAbro321
force-pushed
the
dynamic-rest
branch
from
390abc1 to
48fdf59
Compare
AustinAbro321
changed the title
phillebaba
approved these changes
Sep 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ittacco
pushed a commit
to ittacco/zarf
that referenced
this pull request
Nov 9, 2024
…ys (zarf-dev#3011) Signed-off-by: Austin Abro <[email protected]> Signed-off-by: ittacco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Health checks don't work currently if a CR is health checked in the same package that created the CRD. This problem was from the watcher that we get from pkg/kubernetes so to fix this issue we only need to change the dependency.
Fixes #3010
Checklist before merging