Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Health Checks issue with Helm Releases (potentially all CRDS) #3010

Closed
AustinAbro321 opened this issue Sep 19, 2024 · 0 comments · Fixed by #3011
Closed

Health Checks issue with Helm Releases (potentially all CRDS) #3010

AustinAbro321 opened this issue Sep 19, 2024 · 0 comments · Fixed by #3011
Labels
possible-bug 🐛

Comments

@AustinAbro321
Copy link
Contributor

AustinAbro321 commented Sep 19, 2024 •
edited
Loading

Environment

Device and OS: Ubuntu
App version: v0.39.0
Kubernetes distro being used: k3d

Steps to reproduce

  1. Have a package which deploys flux then deploys flux helm releases
  2. Have health checks on the flux helm releases

Expected result

The health checks will finish when the package is ready

Actual Result

The health checks never finish.

The issue seems to be that Zarf needs to use a dynamic rest mapper in kubernetes for the watcher rather than a static rest mapper. The dynamic mapper will grab resource types at runtime, which is important since package creators can both install and check on CRDs

Severity/Priority

Medium
@github-project-automation github-project-automation bot moved this to Triage in Zarf Sep 19, 2024
This was referenced Sep 19, 2024
Merged
Merged
AustinAbro321 added a commit to defenseunicorns/pkg that referenced this issue Sep 20, 2024
@AustinAbro321
feat: dynamic rest mapper (#129)
2861521 
## Description

Not having a dynamic rest mapper is problematic for Zarf health checks
with CRDs. See [#3010](zarf-dev/zarf#3010)

---------

Signed-off-by: Austin Abro <[email protected]>
@github-project-automation github-project-automation bot moved this from Triage to Done in Zarf Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
possible-bug 🐛
Projects
Zarf
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: health checks issue when crds don't exist prior to package deploys zarf-dev/zarf
1 participant
@AustinAbro321