Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow namespaces to be empty with zarf tools wait-for #2055

Merged
merged 12 commits into from
Oct 11, 2023

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Oct 5, 2023

Description

This fixes an issue with waiting for a namespace when a namespace isn't specified.

Related Issue

Fixes #2054

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 413506d
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6526d98eadff3d000848d7e5

@Racer159 Racer159 added the needs-tests PR Label - Tests required to merge label Oct 5, 2023
@Racer159 Racer159 removed the needs-tests PR Label - Tests required to merge label Oct 5, 2023
Copy link
Contributor

@lucasrod16 lucasrod16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't use correct tabbing on the previous suggestion

otherwise this lgtm

src/test/e2e/31_component_action_cluster_test.go Outdated Show resolved Hide resolved
@Racer159 Racer159 requested a review from lucasrod16 October 11, 2023 17:20
@Racer159 Racer159 changed the title Fix namespace issue with wait fix: allow namespaces to be empty with zarf tools wait-for Oct 11, 2023
@Racer159 Racer159 merged commit 4935cd5 into main Oct 11, 2023
@Racer159 Racer159 deleted the 2054-fix-namespaces-in-wait-for branch October 11, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zarf 0.30.0 wait-for not working in some scenarios
3 participants