Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zarf 0.30.0 wait-for not working in some scenarios #2054

Closed
mjnagel opened this issue Oct 5, 2023 · 0 comments · Fixed by #2055
Closed

Zarf 0.30.0 wait-for not working in some scenarios #2054

mjnagel opened this issue Oct 5, 2023 · 0 comments · Fixed by #2055

Comments

@mjnagel
Copy link
Contributor

mjnagel commented Oct 5, 2023

Environment

Device and OS: Macos, MBP
App version: 0.30.0
Kubernetes distro being used: k3d

Steps to reproduce

Option 1:

  • Build/deploy the below package with zarf 0.29.2 and zarf 0.30.0, against a default k3d cluster:
kind: ZarfPackageConfig
metadata:
  name: test
components:
  - name: bar
    actions:
      onDeploy:
        after:
          - wait:
              cluster:
                kind: APIService
                name: v1beta1.metrics.k8s.io

Option 2:

  • Run the following commands against a default k3d cluster:
zarf-30 tools wait-for apiservice v1beta1.metrics.k8s.io -n default
  ✔  Waiting for apiservice/v1beta1.metrics.k8s.io in namespace default to exist.                                                                                                                               zarf-30 tools wait-for apiservice v1beta1.metrics.k8s.io -n ""
  ⠦  Waiting for apiservice/v1beta1.metrics.k8s.io to exist. (3s)^C                                                                                                                                             zarf-30 tools wait-for apiservice v1beta1.metrics.k8s.io
  ⠦  Waiting for apiservice/v1beta1.metrics.k8s.io to exist. (3s)^C                                                                                                                                             

(the first one passes, the others fail)

Expected result

The wait-for behavior should be the same across these versions.

Actual Result

Wait-for seems to fail in some scenarios, possibly due to namespace handling behavior with the kubectl library update?

Visual Proof (screenshots, videos, text, etc)

Included logs above for CLI behavior.

Severity/Priority

Breaks the BB extension due to the metrics server wait included there.

Racer159 added a commit that referenced this issue Oct 11, 2023
## Description

This fixes an issue with waiting for a namespace when a namespace isn't
specified.

## Related Issue

Fixes #2054

## Type of change

- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Lucas Rodriguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant