Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce utils size #1883

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Reduce utils size #1883

merged 5 commits into from
Jul 6, 2023

Conversation

cmwylie19
Copy link
Contributor

Description

This reduces the size of the dependencies in the transform lib by over ~45Mb.

Related Issue

Fixes #

Relates to #1882

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit abb75fa
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/64a73425acfb310008fdcd4b
😎 Deploy Preview https://deploy-preview-1883--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one little lint issue, but otherwise looks fine

src/pkg/utils/io.go Show resolved Hide resolved
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Racer159 Racer159 enabled auto-merge (squash) July 6, 2023 21:38
@Racer159 Racer159 merged commit 734f880 into zarf-dev:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants