Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve interaction with Zarf messaging for library users #1882

Closed
Racer159 opened this issue Jul 5, 2023 · 1 comment
Closed

Improve interaction with Zarf messaging for library users #1882

Racer159 opened this issue Jul 5, 2023 · 1 comment
Milestone
The Bucket

Comments

@Racer159
Copy link
Contributor

Racer159 commented Jul 5, 2023 •
edited
Loading

Describe what should be investigated or refactored

Currently our message library has the following shortcomings for library users:

  1. it is relatively large and pulls in more than it should - it is also used in other utils and pkg code where it should use a logger interface instead (like the k8s package) - this would help library users keep their code small and light.
  2. it prints more than it should impacting the UX of other CLIs / programs that use Zarf as a library.

Links to any relevant code

image

Additional context

This would help with other projects using Zarf like compiling Zarf as a library in WASM modules for Pepr
@Racer159 Racer159 added this to the The Bucket milestone Jul 5, 2023
@cmwylie19 cmwylie19 mentioned this issue Jul 5, 2023
Merged
5 tasks
Racer159 added a commit that referenced this issue Jul 6, 2023
@cmwylie19 @Racer159
Reduce utils size (#1883)
734f880 
## Description

This reduces the size of the dependencies in the transform lib by over
~45Mb.

## Related Issue

Fixes #
<!-- or -->
Relates to #1882

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Signed-off-by: Case Wylie <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
@Racer159 Racer159 changed the title Reduce message library size Improve interaction with Zarf messaging for library users Oct 26, 2023
@Noxsios
Copy link
Contributor

Noxsios commented Apr 9, 2024

This is happening naturally over time as we transition portions of Zarf to be more true libraries w/ slog.Handler usage.

Closing as this is an over-arching codebase change, not a really actionable, single PR effort.

@Noxsios Noxsios closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
The Bucket
Development

No branches or pull requests
2 participants
@Racer159 @Noxsios