Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine printer logic when interacting with a spinner #1334

Closed
wants to merge 2 commits into from
Closed

Refine printer logic when interacting with a spinner #1334

wants to merge 2 commits into from

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Feb 6, 2023

Description

This improves command output printing and resolves an issue where --no-progress incorrectly displays the command being run.

Related Issue

Fixes #1267

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Feb 6, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit c138931
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/63e1601e1bc7970008904e56

@Racer159
Copy link
Contributor Author

Racer159 commented Feb 7, 2023

superseded by #1338

@Racer159 Racer159 closed this Feb 7, 2023
@Noxsios Noxsios deleted the 1267-console-log-shows-incorrect-commands branch March 21, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@YrrepNoj YrrepNoj Awaiting requested review from YrrepNoj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Console log shows incorrect commands when prepare scripts are run
1 participant
@Racer159