-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console log shows incorrect commands when prepare
scripts are run
#1267
Labels
Comments
@jeff-mccoy data on whether the new |
5 tasks
5 tasks
github-project-automation
bot
moved this from New Requests
to Done
in Zarf Project Board
Feb 8, 2023
Noxsios
pushed a commit
that referenced
this issue
Mar 8, 2023
## Description Updates local image behavior, changing back to crane first with docker as an optional fallback when needed. Large images from docker will still be slow, but should not cause OOM issues and a new warning was added to communicate an alternate approach to speed up local dev with large images. Also cleans up some of the exec package presentation logic. ## Related Issue Fixes #1214 Fixes #1267 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed --------- Co-authored-by: Wayne Starr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
Device and OS: EC2 Ubuntu
App version: 0.23.5
Kubernetes distro being used: n/a
Other:
Steps to reproduce
prepare:
scriptszarf package create
Expected result
Correct commands are logged in "Waiting for command" log messages
Actual Result
Severity/Priority
Low -- The correct commands are run. It's just the logging that is wrong.
Additional Context
The text was updated successfully, but these errors were encountered: