Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console log shows incorrect commands when prepare scripts are run #1267

Closed
RothAndrew opened this issue Jan 26, 2023 · 2 comments · Fixed by #1332
Closed

Console log shows incorrect commands when prepare scripts are run #1267

RothAndrew opened this issue Jan 26, 2023 · 2 comments · Fixed by #1332

Comments

@RothAndrew
Copy link
Contributor

Environment

Device and OS: EC2 Ubuntu
App version: 0.23.5
Kubernetes distro being used: n/a
Other:

Steps to reproduce

  1. Have 2 components, both with prepare: scripts
  2. Run zarf package create

Expected result

Correct commands are logged in "Waiting for command" log messages

Actual Result

image

Severity/Priority

Low -- The correct commands are run. It's just the logging that is wrong.

Additional Context

@RothAndrew
Copy link
Contributor Author

RothAndrew commented Jan 30, 2023

Zarf v0.24.0-rc3 repeatedly shows the first command in the "Running Command" log line.

image

image

@RothAndrew
Copy link
Contributor Author

@jeff-mccoy data on whether the new actions: stuff displayed the same behavior that you asked for.

@github-project-automation github-project-automation bot moved this from New Requests to Done in Zarf Project Board Feb 8, 2023
Noxsios pushed a commit that referenced this issue Mar 8, 2023
## Description

Updates local image behavior, changing back to crane first with docker
as an optional fallback when needed. Large images from docker will still
be slow, but should not cause OOM issues and a new warning was added to
communicate an alternate approach to speed up local dev with large
images. Also cleans up some of the exec package presentation logic.

## Related Issue

Fixes #1214 
Fixes #1267

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Wayne Starr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant