Refactor component composability and skeletons to address bugs and update to newer patterns #2037
Labels
ga
Issues tracking toward Zarf 1.0
Milestone
Comments
Racer159
changed the title
5 tasks
5 tasks
5 tasks
Racer159
added a commit
that referenced
this issue
Nov 1, 2023
## Description
```go
chain, err := composer.NewImportChain(pkg.Components[0], "amd64")
if err != nil {
panic(err)
}
fmt.Println(chain.String())
```
results in:
```
component "k3s" imports "k3s" in packages/distros/k3s, which imports "k3s" in common
```
## Related Issue
Fixes #2037
Fixes #1827
Fixes #1845
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)
## Checklist before merging
- [ ] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed
---------
Signed-off-by: razzle <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe what should be investigated or refactored
There have been a few bugs around component compose that need to be addressed as well as some improved:
Bugs:
Fixes #1827
Fixes #1845
Refactors:
Move skeleton to package build data so that we can tell what is a skeleton package when it is outside of an OCI ref
Simplify the interactions with the new
layoutstruct from the provider / sources refactor.Links to any relevant code
https://github.com/defenseunicorns/zarf/blob/main/src/pkg/packager/compose.go
Additional context
This would greatly simplify component composability and make is more understandable.
The text was updated successfully, but these errors were encountered: