Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-layered imports do not adjust filepaths correctly #1845

Closed
mjnagel opened this issue Jun 23, 2023 · 0 comments · Fixed by #2058
Closed

Multi-layered imports do not adjust filepaths correctly #1845

mjnagel opened this issue Jun 23, 2023 · 0 comments · Fixed by #2058

Comments

@mjnagel
Copy link
Contributor

mjnagel commented Jun 23, 2023

Environment

Device and OS: MBP, macOS
App version: 0.27.1
Kubernetes distro being used: N/A

Steps to reproduce

  1. Clone https://github.com/mjnagel/layers-of-cake
  2. zarf package create
  3. Observe during confirmation that only the "bottom" import has its paths adjusted correctly.

Expected result

All layers of imports should have filepaths adjusted to be relative to the import path.

Actual Result

Only the last imported component will be adjusted correctly. Note that this was reproduced with both 3 & 4 layers, and I assume this could be extended indefinitely.

Visual Proof (screenshots, videos, text, etc)

kind: ZarfPackageConfig
metadata:
  name: parent
components:
- name: file
  required: true
  files:
  - source: leaf/lfile.txt
    target: lfile.txt
  - source: cfile.txt
    target: cfile.txt
  - source: sfile.txt
    target: sfile.txt
  - source: file.txt
    target: file.txt

Severity/Priority

No clear workaround outside of symlinks, etc to make paths work.

Additional Context

This was originally seen with the bigbang extension values files, but it seems to affect all places where imported components need to adjust filepaths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants