Dialogues closed by pressing the escape key #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build is failing because of lint issues. |
|
Sorry about that. Thank you! |
|
This works well, but it would be better if the dialogs were auto focused so that the user doesnt need to select them. |
psiinon
approved these changes
Oct 10, 2019
|
great work @designitsecure ! |
…must be clicked first)
thc202
approved these changes
Oct 28, 2019
|
(Fixed the conflict in the changelog.) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
Dialogues can now be closed by pressing the escape key. However, one thing to note is that the dialogue must be brought into focus by clicking on it first. If you would like me to work on having the dialogue autofocus just let me know.
Please let me know if you need any changes. Thanks!!