Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialogues not properly closed with escape key #71

Closed
thc202 opened this issue Jan 11, 2018 · 6 comments · Fixed by #618
Closed

Dialogues not properly closed with escape key #71

thc202 opened this issue Jan 11, 2018 · 6 comments · Fixed by #618
Assignees
@dscrobonia
Labels
enhancement
Milestone
0.8.0

Comments

@thc202
Copy link
Member

thc202 commented Jan 11, 2018

The HUD dialogues (e.g. alert details) are closed with the escape key but the grey/background layer is not removed.
@thc202
Copy link
Member Author

thc202 commented Jan 11, 2018

(Tested with Firefox 57.0.4 and Chrome 62.0.3202.94.)

@dscrobonia
Copy link
Contributor

Good find. I'll be sure to look back at this when upgrading jquery.

@dscrobonia dscrobonia self-assigned this Jan 11, 2018
@thc202
Copy link
Member Author

thc202 commented Mar 1, 2018

With Vue the dialogues are no longer closed with the escape key. I guess we could change this to support closing the dialogues?

@dscrobonia
Copy link
Contributor

Thanks for the reminder! I did actually look into closing with the escape key. I didn't get it to work and haven't looked too much into it since, but I'm guessing the problem has something to do with being in an iframe. I'll add this issue to the project board so that I don't forget it. :)

@dscrobonia
Copy link
Contributor

Im guessing it will be an easy fix, just glossed over it for now.

@designitsecure
Copy link
Contributor

Hello, After speaking with @psiinon I have worked on this issue and am close to submitting a PR. Thanks!

@designitsecure designitsecure mentioned this issue Oct 7, 2019
Merged
@thc202 thc202 added this to the 0.8.0 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dscrobonia dscrobonia

Labels
enhancement
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

Dialogues closed by pressing the escape key designitsecure/zap-hud
3 participants
@thc202 @dscrobonia @designitsecure