This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
Move handler structures to kopf.structs package #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once the handlers were moved away into its own separate module, it makes no sense to keep the types of some of the handlers' fields in other modules (such as causation). Instead, it should be all together with handlers — and so we can move the whole thing to the `kopf.structs` package eventually (next commit). Because all of them are structs after all, not the reactor's processes.
Because they are structs, after all. Also, in the few following commits, the daemons structs will be introduced, and they need to import and use handlers, from which they were spawned. It would be problematic to import a high-level `reactor.handlers` from a low-level `structs.containers` (if not moved).
Originally, the hope was to reuse them in daemons & timers. But this breaks the semantics of the handlers: patches should be applied on every exit, not only on successes; multiple restarts should be counted & limited and distributed with backoffs; extra daemon restarts are not needed at all if regular retrying works; etc.
🤖 zincr found 0 problems , 0 warnings |
🤖 zincr found 1 problem , 0 warningsDetails on how to resolve are provided below ApprovalsAll proposed changes must be reviewed by project maintainers before they can be merged Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.
|
haikoschol
approved these changes
Mar 26, 2020
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Yet another refactoring PR: just the moves of the code across modules, and some renames. No logic is changed in any way.
Description
It is done as a preparation for both the daemons (#330) and configurable state persistence (#331).
The main change: the handlers are now moved from
kopf.reactortokopf.structs— as they are no more than structs.This allows to keep other structs (such as daemons or configs) to be also stored in
kopf.structsinstead of leaking intokopf.reactorand exploding it. The main different is that thekopf.reactoris for the processes and logic, whilekopf.structsare for data structures with little or no logic (both reactor-involved and generic).There are no user-facing changes or risks.
Issues/PRs
Type of changes
Checklist
CONTRIBUTORS.txt