Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Move handler structures to kopf.structs package #332

Closed
5 tasks done
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed
5 tasks done

[PR] Move handler structures to kopf.structs package #332

kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Labels
archive refactoring Code cleanup without new features added

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by nolar at 2020-03-25 12:23:29+00:00
Original URL: zalando-incubator/kopf#332
Merged by nolar at 2020-03-26 15:34:13+00:00

What do these changes do?

Yet another refactoring PR: just the moves of the code across modules, and some renames. No logic is changed in any way.

Description

It is done as a preparation for both the daemons (#330) and configurable state persistence (#331).

The main change: the handlers are now moved from kopf.reactor to kopf.structs — as they are no more than structs.

This allows to keep other structs (such as daemons or configs) to be also stored in kopf.structs instead of leaking into kopf.reactor and exploding it. The main different is that the kopf.reactor is for the processes and logic, while kopf.structs are for data structures with little or no logic (both reactor-involved and generic).

There are no user-facing changes or risks.

Issues/PRs

Related: #330 #331

Type of changes

  • Refactoring (non-breaking change which does not alter the behaviour)

Checklist

  • The code addresses only the mentioned problem, and this problem only
  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] Move handler structures to kopf.structs package Aug 19, 2020
@kopf-archiver kopf-archiver bot added the refactoring Code cleanup without new features added label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive refactoring Code cleanup without new features added
Projects
None yet
Development

No branches or pull requests

0 participants