Replace dvisvgm builder with apt package #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is a mistake in the Dockerfile as we should use |
|
Not sure why but |
|
Still failing, my guess is that symbolator relies on a system dependency that was removed/updated. Do you reproduce this issue locally? |
I've been having issues running the project locally, hence my over-reliance on the CI here. 🙃 Symbolator was failing because I forgot to update the builder image to Ubuntu 24.04, so it was compiled for Python 3.11 instead of 3.12. |
|
Perfect, thanks! |
jynolen
pushed a commit
to jynolen/kroki
that referenced
this pull request
Dec 3, 2024
Use pre-built Docker image for erd (yuzutech#1754) Restart browser if killed on Mermaid (yuzutech#1745) chore(deps): update java dependencies (yuzutech#1722) chore(deps): update structurizr packages to v2.2.0 (yuzutech#1757) chore(docs): add Ditaa diagram options to diagram-options page (yuzutech#1781) Co-authored-by: Guillaume Grossetie <[email protected]> chore(node): upgrade to Node LTS 20.18.0 (yuzutech#1784) chore(deps): use Node built-in test runner (yuzutech#1785) chore(docs): add hugomods-kroki to list of 3rd-party tools (yuzutech#1724) chore(node): replace mocha + chai by Node test runner and assert modules (yuzutech#1786) chore(deps): replace mocha by Node test runner (yuzutech#1787) chore(bpmn): upgrade dependencies (docker base image, puppeteer, bpmn, pino) (yuzutech#1788) chore(deps): update java testing packages (yuzutech#1772) chore(deps): update dependency rust to v1.82 (yuzutech#1791) chore(deps): update node dependencies (yuzutech#1737) chore(deps): update actions/checkout action to v4.2.1 (yuzutech#1790) chore(deps): update maven plugins (yuzutech#1755) chore(docs): introduce helm deploy method in use kubernetes section (yuzutech#1793) Co-authored-by: Guillaume Grossetie <[email protected]> chore(deps): update java dependencies (yuzutech#1789) chore(deps): update structurizr packages to v3 (major) (yuzutech#1792) chore(deps): upgrade Mermaid to 11.3.0 (yuzutech#1795) chore(deps): bump puppeteer and pino in diagrams.net (yuzutech#1794) chore(deps): update node dependencies (major) (yuzutech#1671) chore(deps): update dependency org.apache.maven.plugins:maven-surefire-plugin to v3.5.2 (yuzutech#1801) chore(deps): update java dependencies to v1.5.12 (yuzutech#1798) chore(deps): update actions/checkout action to v4.2.2 (yuzutech#1797) chore(deps): update dependency mermaid to v11.4.0 (yuzutech#1800) chore(deps): update versions and distributions fix(ditaa): pass argument values as separate arguments ref yuzutech#1803 Version 0.26.0 chore(release): free up disk space on GitHub runner chore(release): allow to manually push a release chore(release): keep the v prefix when creating the release chore(release): fix environment variable assignment chore(release): dynamic run-name when using workflow_dispatch feat: proposal without cheerio fix: lint + kroki unsafe chore(deps): update node dependencies (yuzutech#1737) chore(deps): bump puppeteer and pino in diagrams.net (yuzutech#1794) feat: self contains svg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kroki-builder-dvisvgmDocker builder image with the now available apt package.dvisvgmis available from Ubuntu 24.04 onwards.