Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-built Docker image for erd #1754

Merged
merged 8 commits into from
Aug 19, 2024

Conversation

felixvanoost
Copy link
Contributor

Replaces the kroki-builder-erd Docker image used to build the erd binary with a pre-built image published upstream. This resolves the issue with using erd on ARM64 machines described in #1239 and #1084, and should slightly reduce the build time of the Kroki Docker images.

The maintainer of https://github.com/BurntSushi/erd merged my PR to publish a linux/arm64 Docker image in October 2023 but didn't complete setting up the required ARM64 runner. There's been no further progress since then, so I've created a fork of the project and published the images myself.

@ggrossetie I'm happy to transfer ownership of the fork to you if you'd like to maintain control over it.

Closes #1239
Closes #1084

@felixvanoost felixvanoost changed the title Use pre-built erd Docker image Use pre-built Docker image for erd May 31, 2024
@ggrossetie
Copy link
Member

Hey! thanks for moving this issue forward.

I'm not familiar with the GitHub container repository. Do I need to do something special to activate it?
I guess I will need to update the GitHub Action to use my own ARM64 runner right? Currently, the build is using buildjet-4vcpu-ubuntu-2204-arm. I guess I won't have access to this runner once the project has been transferred to the yuzutech org?

Also, I've noticed that you have a unknown/unknown arch:
image

@felixvanoost
Copy link
Contributor Author

The GitHub container registry should be enabled by default; you don't have to do anything special. All you should need to do is change to your local ARM runner as you described, then update the URL of the image in the Dockerfile.

@ggrossetie
Copy link
Member

@felixvanoost sent you an invite to join the @yuzutech organization, you should be able to transfer the repository

@felixvanoost
Copy link
Contributor Author

felixvanoost commented Jul 24, 2024

@ggrossetie I tried transferring ownership of the repo but I get an error message saying that I need permissions to create public repositories in @yuzutech first.

Untitled

@ggrossetie
Copy link
Member

@felixvanoost I've allowed repository creation, could you please try again? Ref: https://docs.github.com/en/organizations/managing-organization-settings/setting-permissions-for-deleting-or-transferring-repositories

@felixvanoost
Copy link
Contributor Author

@felixvanoost I've allowed repository creation, could you please try again? Ref: https://docs.github.com/en/organizations/managing-organization-settings/setting-permissions-for-deleting-or-transferring-repositories

I successfully transferred it last night. 🚀

@ggrossetie
Copy link
Member

@felixvanoost
Copy link
Contributor Author

@ggrossetie Good to go!

@ggrossetie
Copy link
Member

Many thanks for your work 🙇🏻

@ggrossetie ggrossetie merged commit d96fd25 into yuzutech:main Aug 19, 2024
1 check passed
@felixvanoost felixvanoost deleted the use-erd-native-image branch August 19, 2024 12:21
jynolen pushed a commit to jynolen/kroki that referenced this pull request Dec 3, 2024
Use pre-built Docker image for erd (yuzutech#1754)

Restart browser if killed on Mermaid (yuzutech#1745)

chore(deps): update java dependencies (yuzutech#1722)

chore(deps): update structurizr packages to v2.2.0 (yuzutech#1757)

chore(docs): add Ditaa diagram options to diagram-options page (yuzutech#1781)

Co-authored-by: Guillaume Grossetie <[email protected]>

chore(node): upgrade to Node LTS 20.18.0 (yuzutech#1784)

chore(deps): use Node built-in test runner (yuzutech#1785)

chore(docs): add hugomods-kroki to list of 3rd-party tools (yuzutech#1724)

chore(node): replace mocha + chai by Node test runner and assert modules (yuzutech#1786)

chore(deps): replace mocha by Node test runner (yuzutech#1787)

chore(bpmn): upgrade dependencies (docker base image, puppeteer, bpmn, pino) (yuzutech#1788)

chore(deps): update java testing packages (yuzutech#1772)

chore(deps): update dependency rust to v1.82 (yuzutech#1791)

chore(deps): update node dependencies (yuzutech#1737)

chore(deps): update actions/checkout action to v4.2.1 (yuzutech#1790)

chore(deps): update maven plugins (yuzutech#1755)

chore(docs): introduce helm deploy method in use kubernetes section (yuzutech#1793)

Co-authored-by: Guillaume Grossetie <[email protected]>

chore(deps): update java dependencies (yuzutech#1789)

chore(deps): update structurizr packages to v3 (major) (yuzutech#1792)

chore(deps): upgrade Mermaid to 11.3.0 (yuzutech#1795)

chore(deps): bump puppeteer and pino in diagrams.net (yuzutech#1794)

chore(deps): update node dependencies (major) (yuzutech#1671)

chore(deps): update dependency org.apache.maven.plugins:maven-surefire-plugin to v3.5.2 (yuzutech#1801)

chore(deps): update java dependencies to v1.5.12 (yuzutech#1798)

chore(deps): update actions/checkout action to v4.2.2 (yuzutech#1797)

chore(deps): update dependency mermaid to v11.4.0 (yuzutech#1800)

chore(deps): update versions and distributions

fix(ditaa): pass argument values as separate arguments

ref yuzutech#1803

Version 0.26.0

chore(release): free up disk space on GitHub runner

chore(release): allow to manually push a release

chore(release): keep the v prefix when creating the release

chore(release): fix environment variable assignment

chore(release): dynamic run-name when using workflow_dispatch

feat: proposal without cheerio

fix: lint + kroki unsafe

chore(deps): update node dependencies (yuzutech#1737)

chore(deps): bump puppeteer and pino in diagrams.net (yuzutech#1794)

feat: self contains svg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error generating erd with Docker on ARM Docker containers for more platforms
2 participants