Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove one line of log in setCrashContext #4725

Open
wants to merge 1 commit into
base: 25.lts.1+
Choose a base branch
from
Open

Remove one line of log in setCrashContext #4725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion starboard/android/apk/app/src/main/java/dev/cobalt/coat/StarboardBridge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,7 +775,6 @@ void reportFullyDrawn() {
@SuppressWarnings("unused")
@UsedByNative
public void setCrashContext(String key, String value) {
Log.i(TAG, "setCrashContext Called: " + key + ", " + value);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine and I don't think this is strictly needed. We should talk about this offline though. The item flagged as PII was just a UserAgent string. If that's PII, the every log we send is PII. That seems wrong.

crashContext.put(key, value);
if (this.crashContextUpdateHandler != null) {
this.crashContextUpdateHandler.onCrashContextUpdate();
Expand Down
Loading