Remove one line of log in setCrashContext #4725
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The production log was identified as pii. b/370167229
joeltine
reviewed
Jan 22, 2025
| @@ -775,7 +775,6 @@ void reportFullyDrawn() { | |||
| @SuppressWarnings("unused") | |||
| @UsedByNative | |||
| public void setCrashContext(String key, String value) { | |||
| Log.i(TAG, "setCrashContext Called: " + key + ", " + value); | |||
There was a problem hiding this comment.
Seems fine and I don't think this is strictly needed. We should talk about this offline though. The item flagged as PII was just a UserAgent string. If that's PII, the every log we send is PII. That seems wrong.
joeltine
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The production log was identified as pii.
b/370167229