Fix flags in chromium* args.gn files #4420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niranjanyardi
force-pushed
the
fix_flgs_in_args_gn
branch
from
a80a33e to
5fe810c
Compare
oxve
approved these changes
Nov 13, 2024
imindich
pushed a commit
to imindich/cobalt
that referenced
this pull request
Nov 14, 2024
b/377271824 While renaming the chromium and cobalt builders: youtube#4399 args.gn files was not set correctly. This PR sets the appropriate args.gn for chromium and cobalt builds for all platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/377271824
While renaming the chromium and cobalt builders: #4399 args.gn files was not set correctly.
This PR sets the appropriate args.gn for chromium and cobalt builds for all platforms.