Skip to content

Commit

Permalink
Fix flags in chromium* args.gn files (#4420)
Browse files Browse the repository at this point in the history
b/377271824

While renaming the chromium and cobalt builders:
#4399 args.gn files was not set
correctly.
This PR sets the appropriate args.gn for chromium and cobalt builds for
all platforms.
  • Loading branch information
niranjanyardi authored Nov 13, 2024
1 parent 9cd9974 commit 9444174
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 8 deletions.
1 change: 0 additions & 1 deletion cobalt/build/configs/chromium_android-arm/args.gn
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
target_os = "android"
target_cpu = "arm"
is_cobalt = false
treat_warnings_as_errors = false
1 change: 0 additions & 1 deletion cobalt/build/configs/chromium_android-arm64/args.gn
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
target_os = "android"
target_cpu = "arm64"
is_cobalt = false
treat_warnings_as_errors = false
1 change: 0 additions & 1 deletion cobalt/build/configs/chromium_android-x86/args.gn
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
target_os = "android"
target_cpu = "x86"
is_cobalt = false
treat_warnings_as_errors = false
5 changes: 0 additions & 5 deletions cobalt/build/configs/chromium_linux-x64x11/args.gn
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,3 @@ is_cobalt = false

# TODO(b/376141256): Decide if this flag is needed here or in .gclient file
chrome_pgo_phase = 0

# Vulkan is a new rendering (and presentation, and more) API intended to replace
# E/GL(ES). Partners are only required to support upto GLES 2.0 : https://developers.google.com/youtube/cobalt/docs/reference/starboard/modules/16/gles#gles_version
# Disable Vulkan until we formally decide to support it.
enable_vulkan = false
5 changes: 5 additions & 0 deletions cobalt/build/configs/linux-x64x11/args.gn
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,8 @@ use_ozone = true

# TODO(b/376141256): Decide if this flag is needed here or in .gclient file
chrome_pgo_phase = 0

# Vulkan is a new rendering (and presentation, and more) API intended to replace
# E/GL(ES). Partners are only required to support upto GLES 2.0 : https://developers.google.com/youtube/cobalt/docs/reference/starboard/modules/16/gles#gles_version
# Disable Vulkan until we formally decide to support it.
enable_vulkan = false

0 comments on commit 9444174

Please sign in to comment.