Fix the feature test and turn on in CI #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2060 +/- ##
==========================================
- Coverage 64.82% 64.78% -0.04%
==========================================
Files 129 129
Lines 14765 14768 +3
==========================================
- Hits 9571 9568 -3
- Misses 5194 5200 +6 |
utam0k
reviewed
Jun 18, 2023
utam0k
reviewed
Jun 18, 2023
utam0k
reviewed
Jun 18, 2023
Signed-off-by: yihuaf <[email protected]>
utam0k
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature test has been broken for unknown amount of time. The libcgroups and libcontainer has been tested with all v1, v2, and systemd feature turn on. However, individual features are not working. This PR fix this by introduce a stub implementation of libcgroup implementation if the feature is not turned on. Due to how the code is structured, we can't completely remove the reference when a feature is turned off. So a stub is required.
Fix #2046
Other fixes:
musltest are separated out to a different test script outside of the feature test, since the goal for the test less about features, but more about targetingmusl. The two test cases are passing, but I am following up with another PR to put these tests into CI.