Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcgroup build is broken for individual feature v1, v2 or systemd #2046

Closed
yihuaf opened this issue Jun 13, 2023 · 2 comments · Fixed by #2060
Closed

libcgroup build is broken for individual feature v1, v2 or systemd #2046

yihuaf opened this issue Jun 13, 2023 · 2 comments · Fixed by #2060
Assignees

Comments

@yihuaf
Copy link
Collaborator

yihuaf commented Jun 13, 2023

Currently, we default the libcgroup feature to [v1, v2, systemd], so this went under our radar. However, if we compile libcontainer with individual features, the libcgroups fails to compile.

For example, this will fail.

cargo build --no-default-features --package libcontainer --features v2
@yihuaf yihuaf self-assigned this Jun 13, 2023
@yihuaf yihuaf added the bug label Jun 13, 2023
@izissise
Copy link

I tried to update libcontainer/libcgroup in aurae but I got this error aswell

@yihuaf
Copy link
Collaborator Author

yihuaf commented Jun 17, 2023

I tried to update libcontainer/libcgroup in aurae but I got this error aswell

Yes, it is currently broken. We did not do a good job keeping this usecase working. I have a fix locally already, so I am hoping this can unblock you next week. I will follow up with works to make libcontainer tests running in CI so it is better maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants