Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Prometheus PVC Spec Syntax Error #650

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Revise Prometheus PVC Spec Syntax Error #650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60ad2eb
Revise prometheus pvc spec syntax error
krapie Oct 18, 2023
644db4c
Upgrade yorkie-monitoring helm chart version
krapie Oct 18, 2023
29906ca
Sync chart version with Yorkie version
krapie Oct 18, 2023
af75197
Update MAINTAINING.md version updating guide
krapie Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions MAINTAINING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
- Update `YORKIE_VERSION` in [Makefile](https://github.com/yorkie-team/yorkie/blob/main/Makefile#L1).
- Update `version` and `appVersion` in [yorkie-cluster Helm Chart](https://github.com/yorkie-team/yorkie/blob/main/build/charts/yorkie-cluster/Chart.yaml#L16-L17).
- If `yorkie-monitoring` or `yorkie-argocd` Helm Chart have changes, you also need to update `version` and `appVersion` for each chart.
- [yorkie-monitoring Helm Chart](https://github.com/yorkie-team/yorkie/blob/main/build/charts/yorkie-monitoring/Chart.yaml#L16-L17)
- [yorkie-argocd Helm Chart](https://github.com/yorkie-team/yorkie/blob/main/build/charts/yorkie-argocd/Chart.yaml#L16-L17)
- [yorkie-monitoring Helm Chart](https://github.com/yorkie-team/yorkie/blob/main/build/charts/yorkie-monitoring/Chart.yaml#L16-L17)
- [yorkie-argocd Helm Chart](https://github.com/yorkie-team/yorkie/blob/main/build/charts/yorkie-argocd/Chart.yaml#L16-L17)
- Also, you need to update `helmChartTargetRevision` in `yorkie-argocd` Helm Chart's [values.yaml](https://github.com/yorkie-team/yorkie/blob/main/build/charts/yorkie-argocd/values.yaml#L13)

### 2. Write changelog of this version in [CHANGELOG.md](https://github.com/yorkie-team/yorkie/blob/main/CHANGELOG.md).

Expand Down
4 changes: 2 additions & 2 deletions build/charts/yorkie-monitoring/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ maintainers:

sources:
- https://github.com/yorkie-team/yorkie
version: 0.4.0
appVersion: "0.4.0"
version: 0.4.7
appVersion: "0.4.7"
kubeVersion: ">=1.24.0-0"

keywords:
Expand Down
21 changes: 9 additions & 12 deletions build/charts/yorkie-monitoring/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,18 +164,15 @@ kube-prometheus-stack:

# Prometheus StorageSpec for persistent data
# ref: https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/user-guides/storage.md
#
storageSpec: {}
# Using PersistentVolumeClaim
#
volumeClaimTemplate:
spec:
# storageClassName: gluster
accessModes: ["ReadWriteOnce"]
resources:
requests:
storage: 1Gi
selector: {}
storageSpec:
# Using PersistentVolumeClaim
volumeClaimTemplate:
spec:
# storageClassName: gluster
accessModes: ["ReadWriteOnce"]
resources:
requests:
storage: 1Gi

prometheus-node-exporter:
# fullnameOverride should be {{monitoring.name}} + "prometheus-node-exporter"
Expand Down