Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Prometheus PVC Spec Syntax Error #650

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Conversation

krapie
Copy link
Member

@krapie krapie commented Oct 18, 2023

What this PR does / why we need it:

Revise Prometheus PVC spec syntax error.

I found out that the yorkie-monitoring helm chart was not storing prometheus metrics, which leads to data loss of metrics every time a node goes down (e.g., EC2 spot instance goes down).

This was because the helm chart syntax of volumeClaimTemplate was wrong (it was not linked to storageSpec). Therefore, I corrected the syntax to make Prometheus successfully claim PVC.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@krapie krapie added the bug 🐞 Something isn't working label Oct 18, 2023
@krapie krapie requested a review from hackerwins October 18, 2023 13:12
@krapie krapie self-assigned this Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2b431e0) 48.86% compared to head (af75197) 48.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #650   +/-   ##
=======================================
  Coverage   48.86%   48.86%           
=======================================
  Files          69       69           
  Lines       10082    10082           
=======================================
  Hits         4927     4927           
  Misses       4635     4635           
  Partials      520      520           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I left a comment.

build/charts/yorkie-monitoring/Chart.yaml Outdated Show resolved Hide resolved
@krapie krapie requested a review from hackerwins October 18, 2023 13:31
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krapie krapie force-pushed the revise-prometheus-pvc branch from de834c6 to af75197 Compare October 18, 2023 13:55
@hackerwins hackerwins merged commit 37ef0ea into main Oct 18, 2023
1 check passed
@hackerwins hackerwins deleted the revise-prometheus-pvc branch October 18, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants