-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise Prometheus PVC Spec Syntax Error #650
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
=======================================
Coverage 48.86% 48.86%
=======================================
Files 69 69
Lines 10082 10082
=======================================
Hits 4927 4927
Misses 4635 4635
Partials 520 520 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. I left a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
de834c6
to
af75197
Compare
What this PR does / why we need it:
Revise Prometheus PVC spec syntax error.
I found out that the
yorkie-monitoring
helm chart was not storing prometheus metrics, which leads to data loss of metrics every time a node goes down (e.g., EC2 spot instance goes down).This was because the helm chart syntax of
volumeClaimTemplate
was wrong (it was not linked tostorageSpec
). Therefore, I corrected the syntax to make Prometheus successfully claim PVC.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: