-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make attributes display properly in dashboard #564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you sent your first PR. 💪
Next, it would be good to do the below two things:
- Fix the error on the CI test
- Add related test code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reflecting on the requests.
Next, we need to remove unnecessary changes from this PR.
crdt/internal_document.go, database/database.go, memory/database.go
bd60067
to
abf17ac
Compare
… tests Attributes should be displayed in dashboad JSON format data, and, because we fixed the JSON display for when attributes are added, we should write additional unit tests for them.
Codecov Report
@@ Coverage Diff @@
## main #564 +/- ##
==========================================
- Coverage 51.94% 51.91% -0.04%
==========================================
Files 67 67
Lines 6847 6851 +4
==========================================
Hits 3557 3557
- Misses 2851 2855 +4
Partials 439 439
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
What this PR does / why we need it:
(Bug fix)
Which issue(s) this PR fixes:
Fixes yorkie-team/dashboard#128
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: