Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug where attributes set in Tree are not displayed in the dashboard #128

Closed
hackerwins opened this issue Jun 26, 2023 · 1 comment · Fixed by yorkie-team/yorkie#564
Closed
Labels
bug 🐞 Something isn't working good first issue 🐤 Good for newcomers

Comments

@hackerwins
Copy link
Member

Description:

There is a bug where attributes set in Tree are not displayed in the dashboard.

Dashboard retrieves detailed information about a document by calling the GetDocument API from the server. It is suspected that attributes might be missing in the snapshot generated by the server.

Dashboard:

getDocumentAsync({
projectName,
documentKey,
}),

Server: https://github.com/yorkie-team/yorkie/blob/525cacf2747f53187e41fd495e41f1b26e0a5d4e/server/rpc/admin_server.go#L209-L233

Why:

@hackerwins hackerwins added the bug 🐞 Something isn't working label Jun 26, 2023
@krapie
Copy link
Member

krapie commented Jun 26, 2023

I think this is because codes for marshalling tree attributes are missing in Marshal() in crdt.Tree.

https://github.com/yorkie-team/yorkie/blob/525cacf2747f53187e41fd495e41f1b26e0a5d4e/pkg/document/crdt/tree.go#L286

(And GetDocummentSummary() uses Marshal() for creating snapshot).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working good first issue 🐤 Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants