Add shard key in context #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #499 +/- ##
==========================================
+ Coverage 48.33% 48.60% +0.26%
==========================================
Files 69 69
Lines 5896 5919 +23
==========================================
+ Hits 2850 2877 +27
+ Misses 2705 2696 -9
- Partials 341 346 +5
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
2 tasks
2 tasks
2 tasks
7hong13
added a commit
to yorkie-team/yorkie-android-sdk
that referenced
this pull request
Jun 5, 2023
* Apply integration of SDK and admin RPC server * add x-shard-key(ref: yorkie-team/yorkie#499) --------- Co-authored-by: Kevin Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Append shard key metadata to SDK's requests.
We recently introduced key-based sharding on the cluster. This commit appends the shard key(
x-shard-key) to SDK's requests to do load balancing from Destination Rule in Istio.We can group SDK APIs into project-based and document-based.
The value of
x-shard-keyof project-based APIs such asActivateClientconsists only ofpublic-api-keythat can represent a project.And the value of
x-shard-keyof document-based APIs such asAttachDocumentis{public-api-key}/{document-key}that can represent a document in the project.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: