Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x-shard-key to APIs #72

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Add x-shard-key to APIs #72

merged 2 commits into from
Jul 7, 2023

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented May 30, 2023

What this PR does / why we need it?

Add x-shard-key to APIs

Any background context you want to provide?

Fixes #70

What are the relevant tickets?

Related to yorkie-team/yorkie#499

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum added the enhancement 🌟 New feature or request label May 30, 2023
@humdrum humdrum requested a review from hackerwins May 30, 2023 07:15
@humdrum humdrum self-assigned this May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #72 (f6b4ed9) into main (80eeb8d) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   56.94%   56.84%   -0.11%     
==========================================
  Files          92       92              
  Lines       13951    13976      +25     
==========================================
  Hits         7945     7945              
- Misses       6006     6031      +25     
Impacted Files Coverage Δ
Sources/Core/Auth.swift 0.00% <0.00%> (ø)
Sources/Core/Client.swift 0.67% <0.00%> (-0.02%) ⬇️

@humdrum humdrum added this to the 0.3.4 milestone Jun 9, 2023
@humdrum humdrum requested review from 7hong13, chacha912 and myupage and removed request for hackerwins June 22, 2023 06:32
@humdrum humdrum merged commit 48e6322 into main Jul 7, 2023
@humdrum humdrum deleted the shard_key branch July 7, 2023 01:34
@humdrum humdrum modified the milestones: 0.3.4, 0.3.5 Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add x-shard-key to APIs
3 participants