-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Client.subscribe #789
Conversation
33d5fb7
to
e146411
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
==========================================
- Coverage 80.46% 80.28% -0.18%
==========================================
Files 59 59
Lines 4432 4439 +7
Branches 890 898 +8
==========================================
- Hits 3566 3564 -2
- Misses 604 612 +8
- Partials 262 263 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. 👍
@chacha912 It would be good to update the documentation for the next release. 🙏 |
What this PR does / why we need it?
In this PR,
Client.subscribe()
was removed, and topicsconnection
andsync
were added todocument.subscribe()
.Any background context you want to provide?
What are the relevant tickets?
Fixes #788, #771
Checklist