Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Client eventStream #164

Merged
merged 1 commit into from
May 17, 2024
Merged

Remove Client eventStream #164

merged 1 commit into from
May 17, 2024

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented May 16, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum requested review from myupage and chacha912 May 16, 2024 09:25
@humdrum humdrum self-assigned this May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 21.91781% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 40.92%. Comparing base (bacbf9c) to head (c2fd5d1).

Files Patch % Lines
Tests/Integration/ClientIntegrationTests.swift 0.00% 25 Missing ⚠️
Sources/Document/Document.swift 42.10% 22 Missing ⚠️
Sources/Core/Client.swift 0.00% 7 Missing ⚠️
Sources/Document/DocEvent.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   40.95%   40.92%   -0.03%     
==========================================
  Files         105      104       -1     
  Lines       17936    17946      +10     
==========================================
  Hits         7345     7345              
- Misses      10591    10601      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@humdrum humdrum merged commit cde554c into main May 17, 2024
3 checks passed
@humdrum humdrum deleted the remove-client-subscribe branch May 17, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants