Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

サーバー情報にリバーシのバージョンを表示する #384

Merged
merged 10 commits into from
Aug 29, 2024

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Aug 29, 2024

What

リモートサーバー情報にリバーシのバージョンを追加
リモートユーザーをリバーシに招待する時、相手のバージョンを確認する

Why

相手のサーバーの対応状況を確認できるように

Additional info (optional)

resolve: #378
#379 で発生した正しく対戦設定まで進めない不具合を修正してある

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 42 lines in your changes missing coverage. Please review.

Project coverage is 40.51%. Comparing base (4fe3dc8) to head (46d2527).

Files with missing lines Patch % Lines
packages/frontend/src/pages/reversi/index.vue 0.00% 29 Missing ⚠️
packages/frontend/src/pages/instance-info.vue 0.00% 4 Missing ⚠️
packages/backend/src/core/ReversiService.ts 0.00% 3 Missing ⚠️
...ges/frontend/src/components/MkInstanceCardMini.vue 0.00% 2 Missing ⚠️
...s/backend/src/core/FetchInstanceMetadataService.ts 0.00% 1 Missing ⚠️
...ckend/src/core/activitypub/models/ApGameService.ts 0.00% 1 Missing ⚠️
...backend/src/core/entities/InstanceEntityService.ts 0.00% 1 Missing ⚠️
...ges/backend/src/core/entities/MetaEntityService.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #384      +/-   ##
===========================================
+ Coverage    40.45%   40.51%   +0.05%     
===========================================
  Files         1660     1660              
  Lines       222730   222782      +52     
  Branches      2860     3793     +933     
===========================================
+ Hits         90104    90256     +152     
+ Misses      132017   131918      -99     
+ Partials       609      608       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 29, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -85932,6 +85932,12 @@
               "string",
               "null"
             ]
+          },
+          "reversiVersion": {
+            "type": [
+              "string",
+              "null"
+            ]
           }
         },
         "required": [
@@ -87284,6 +87290,9 @@
               "global"
             ],
             "default": "local"
+          },
+          "reversiVersion": {
+            "type": "string"
           }
         },
         "required": [
@@ -87338,7 +87347,8 @@
           "serverRules",
           "themeColor",
           "policies",
-          "noteSearchableScope"
+          "noteSearchableScope",
+          "reversiVersion"
         ]
       },
       "MetaDetailedOnly": {

Get diff files from Workflow Page

@kozakura913 kozakura913 self-assigned this Aug 29, 2024
@kozakura913 kozakura913 added this to the yojo0.6.0 milestone Aug 29, 2024
@kozakura913 kozakura913 merged commit 7f1bc7b into yojo-art:develop Aug 29, 2024
28 of 29 checks passed
@kozakura913 kozakura913 deleted the nodeinfo_reversi_db branch August 29, 2024 13:53
@kozakura913 kozakura913 mentioned this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants