Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeinfoにリバーシ連合の機能レベルを含める #379

Merged
merged 6 commits into from
Aug 27, 2024

Conversation

kozakura913
Copy link
Collaborator

#378 の対応状況の公開部分。対応状況の確認部分は別PRで出す

semverにした都合で部分的実装はできない
後で機能ネゴシエーション追加するかも

バージョン末尾の-yojoは実装名

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link
Contributor

github-actions bot commented Aug 27, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 24.00000% with 38 lines in your changes missing coverage. Please review.

Project coverage is 38.75%. Comparing base (1087514) to head (82632c3).
Report is 1 commits behind head on develop.

Files Patch % Lines
packages/backend/src/core/ReversiService.ts 20.00% 32 Missing ⚠️
...ckend/src/core/activitypub/models/ApGameService.ts 20.00% 4 Missing ⚠️
...ckages/backend/src/server/NodeinfoServerService.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #379      +/-   ##
===========================================
- Coverage    38.76%   38.75%   -0.01%     
===========================================
  Files         1655     1655              
  Lines       215984   216033      +49     
  Branches      3687     2842     -845     
===========================================
+ Hits         83722    83729       +7     
- Misses      131614   131695      +81     
+ Partials       648      609      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 merged commit a8da3e9 into yojo-art:develop Aug 27, 2024
24 of 26 checks passed
@kozakura913 kozakura913 deleted the nodeinfo_reversi_version branch August 27, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants