Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing extractor for staticmesh product type #70

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Aug 30, 2024

Changelog Description

This PR is to add missing fbx extractor for staticMesh product type and also use staticMesh as product type instead of unrealStaticMesh to align with the unreal workflow to other dccs

Additional info

We need to discuss the use case of this product type in Unreal to other DCCs

Testing notes:

  1. Select Asset and create staticmesh instance
  2. Publish

@LiborBatek
Copy link
Member

@moonyuet should the testing include the new unrealasset template when testing this PR? or not neccessary atm? thx

@moonyuet
Copy link
Member Author

moonyuet commented Sep 2, 2024

@moonyuet should the testing include the new unrealasset template when testing this PR? or not neccessary atm? thx

@LiborBatek no need to include that template. it would use the existing unreal template instead.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gives me following error when trying to Publish:

image

Traceback (most recent call last):
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\dependency_packages\ayon_2406251801_windows.zip\dependencies\pyblish\plugin.py", line 528, in __explicit_process
    runner(*args)
  File "c:\Work\REPO\ayon-unreal\client\ayon_unreal\plugins\publish\extract_fbx.py", line 35, in process
    task.set_editor_property('object', asset_names)
TypeError: AssetExportTask: Failed to convert type 'str' to property 'Object' (ObjectProperty) for attribute 'object' on 'AssetExportTask'
  TypeError: NativizeProperty: Cannot nativize 'str' as 'Object' (ObjectProperty)
    TypeError: NativizeObject: Cannot nativize 'str' as 'Object' (allowed Class type: 'Object')

@moonyuet moonyuet marked this pull request as draft September 2, 2024 14:19
@moonyuet moonyuet marked this pull request as ready for review September 3, 2024 06:50
@moonyuet moonyuet requested a review from LiborBatek September 3, 2024 06:51
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now Publish of staticMesh goes well and also loading it back seems fine!

Screenshot 2024-09-03 095252

small note: when published staticMesh loaded back into UE it has no same amount of shader slots but just one (matter of FBX options?? when producing that staticMesh?)

but other than that works well:

Screenshot 2024-09-03 095641

@moonyuet moonyuet merged commit 430df92 into develop Sep 3, 2024
1 check passed
@moonyuet moonyuet deleted the enhancement/adding_missing_extractor_for_staticMesh_product_type branch September 3, 2024 08:20
@antirotor antirotor added the type: enhancement Improvement of existing functionality or minor addition label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants