Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure instance members are always list value for publishing uasset/Uasset loader can load the uasset #69

Merged
merged 7 commits into from
Sep 2, 2024

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Aug 29, 2024

Changelog Description

Make sure the instance members are always list value
Related issue: #65, #64, #63

Additional info

Please the PR along with this ticket ynput/ayon-core#859
And with this setting below or with the backend ticket ynput/ayon-backend#328.
image

name: unrealuasset
directory: {root[work]}/{project[name]}/{hierarchy}/{folder[name]}/publish/{product[type]}/{product[name]}/{@version}
filename: {originalBasename}.{ext}

***There are some limitations for loading the uasset/umap btw. You need to perform "delete" the files manually to make it visible. (which is strange) (6039c80)

https://github.com/user-attachments/assets/739cf10e-e119-470b-81c3-43d7504114eb

Demonstration:

umap_test.mp4

Testing notes:

  1. Create UAsset/Umap/Camera Instance
  2. Close the publisher
  3. Open the publisher again
  4. Publish
  5. Should be published successfully without error.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesnt fail on me when performing Publish for Uasset but results into just _CON entity in the publish folder.... is that correct??

Screenshot 2024-08-29 163614

and when loaded via AYON>Load

image

@moonyuet
Copy link
Member Author

moonyuet commented Aug 29, 2024

It doesnt fail on me when performing Publish for Uasset but results into just _CON entity in the publish folder.... is that correct??

Screenshot 2024-08-29 163614

have you tried with the related PR in ayon-core and ayon-backend altogether?

@moonyuet moonyuet requested a review from LiborBatek August 29, 2024 16:44
@LiborBatek
Copy link
Member

@moonyuet nope, sry my bad....didnt pull those other PRs

@moonyuet moonyuet changed the title Make sure instance members are always list value Make sure instance members are always list value for publishing uasset/Uasset loader can load the uasset Aug 30, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with related ayon-core PR pulled together with this one, I was able to publish
Level uasset without any errors (by just using local data sitting inside that level not refering any external data (actors) )

Screenshot 2024-08-30 152135

and been also able to AYON>Load the published uasset level

Screenshot 2024-08-30 152227

LGTM in essence!

@moonyuet moonyuet merged commit 5eadf8c into develop Sep 2, 2024
1 check passed
@moonyuet moonyuet deleted the bugfix/make_sure_instances_members_is_list branch September 2, 2024 07:54
@antirotor antirotor added the type: enhancement Improvement of existing functionality or minor addition label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants